Skip to content

[rb] Bump prism to 1.6.0 #16450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 19, 2025
Merged

[rb] Bump prism to 1.6.0 #16450

merged 5 commits into from
Oct 19, 2025

Conversation

@Earlopain
Copy link
Contributor

@Earlopain Earlopain commented Oct 16, 2025 •
edited by qodo-merge-pro bot
Loading

User description

This new version was just released and hopefully contains a fix for the build failure.

I did not manage to reproduce it locally, so I want to see what CI has to say about it.

🔗 Related Issues

Followup to #16437

🔄 Types of changes

  • Chore

PR Type

Enhancement

Description

  • Bump prism gem from 1.4.0 to 1.6.0

  • Remove version constraint that blocked prism 1.5+

  • Resolve build failure with newer prism versions

Diagram Walkthrough

flowchart LR
  A["prism 1.4.0<br/>with version constraint"] -- "Update dependency" --> B["prism 1.6.0<br/>no constraint"]
  C["Build failure<br/>in prism 1.5+"] -- "Fixed in 1.6.0" --> B
Loading

File Walkthrough
Relevant files
Dependencies
MODULE.bazel
Update prism version hash in Bazel                                             

MODULE.bazel

  • Updated prism dependency hash from 1.4.0 to 1.6.0
  • Changed hash value to reflect new version
 +1/-1     
Gemfile
Remove prism version constraint                                                   

rb/Gemfile

  • Removed version constraint limiting prism to < 1.5
  • Removed associated comment about build error
  • Allows prism 1.6.0 to be used
 +0/-4     

@Earlopain
[rb] Bump prism to 1.6.0
28287eb 
This new version was just released and hopefully contains a fix for the build failure
@selenium-ci selenium-ci added C-rb Ruby Bindings B-build Includes scripting, bazel and CI integrations labels Oct 16, 2025
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Oct 16, 2025 •
edited
Loading

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪
🎫 No ticket provided 
- [ ] Create ticket/issue <!-- /create_ticket --create_ticket=true -->

</details></td></tr>
Codebase Duplication Compliance
⚪
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
⚪
No custom compliance provided

Follow the guide to enable custom compliance check.

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Oct 16, 2025 •
edited
Loading

PR Code Suggestions ✨

No code suggestions found for the PR.

@cgoldberg
Copy link
Member

I want to see what CI has to say about it.

it's running now

@Earlopain
Copy link
Contributor Author

Thanks. Build seems to pass now

@diemol diemol merged commit 83f5f77 into SeleniumHQ:trunk Oct 19, 2025
22 checks passed
This was referenced Oct 25, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Merged
Closed
This was referenced Oct 26, 2025
Closed
Merged
Merged
Open
Merged
Open
Open
Merged
Open
Merged
Open
Open
Closed
Closed
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

B-build Includes scripting, bazel and CI integrations C-rb Ruby Bindings Review effort 1/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Earlopain @cgoldberg @diemol @selenium-ci